-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prometheus-blackbox-exporter] define metricRelabelings in selfservicemonitor.yaml to handle additionalMetricsRelabels #4303
Merged
monotek
merged 13 commits into
prometheus-community:main
from
Sheikh-Abubaker:additionalMetricsRelabels-pr
May 13, 2024
Merged
[prometheus-blackbox-exporter] define metricRelabelings in selfservicemonitor.yaml to handle additionalMetricsRelabels #4303
monotek
merged 13 commits into
prometheus-community:main
from
Sheikh-Abubaker:additionalMetricsRelabels-pr
May 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sheikh-Abubaker <[email protected]>
Sheikh-Abubaker
requested review from
desaintmartin,
gianrubio,
monotek and
rsotnychenko
as code owners
February 27, 2024 10:43
Signed-off-by: Sheikh-Abubaker <[email protected]>
…helm-charts into additionalMetricsRelabels-pr
…helm-charts into additionalMetricsRelabels-pr
…helm-charts into additionalMetricsRelabels-pr
monotek
requested changes
Mar 15, 2024
Signed-off-by: Sheikh-Abubaker <[email protected]>
…helm-charts into additionalMetricsRelabels-pr
…ikh-Abubaker/prometheus-helm-charts into additionalMetricsRelabels-pr
Sheikh-Abubaker
changed the title
[prometheus-blackbox-exporter] defined metricRelabelings in selfservicemonitor.yaml to handle additionalMetricsRelabels
[prometheus-blackbox-exporter] define metricRelabelings in selfservicemonitor.yaml to handle additionalMetricsRelabels
Mar 21, 2024
…helm-charts into additionalMetricsRelabels-pr
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
monotek
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer
Generated ServiceMonitor resource after defining metricRelabelings in selfservicemonitor.yaml, and when additionalMetricsRelabels set to an empty list.
additionalMetricsRelabels changed to empty list due to this warning
Checklist
[prometheus-couchdb-exporter]
)